Skip to content

Name the Spin adapter in the after-response capability error - #515

Open
prk-Jr wants to merge 3 commits into
feature/478-cloudflare-after-responsefrom
feature/483-spin-after-response-error
Open

prk-Jr wants to merge 3 commits into
feature/478-cloudflare-after-responsefrom
feature/483-spin-after-response-error

Conversation

@prk-Jr

@prk-Jr prk-Jr commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Spin does not run after-response tasks. Before this change, ctx.after_response(budget, task) on Spin fell through to core's generic 501 after-response tasks are not supported by this adapter. That error looks the same as a bare core context or an adapter that forgot to install a scheduler.
  • Every converted Spin request now carries a scheduler that rejects the task. It returns 501 Not Implemented (kind not_implemented) with after-response tasks are not supported by the Spin adapter, exported as edgezero_adapter_spin::AFTER_RESPONSE_UNSUPPORTED. The task is dropped without being polled.
  • One deliberate status change. A zero budget on Spin used to return 501, because core found no handle and refused before checking the budget. It now returns 500, because core rejects a zero budget before calling any installed scheduler. Axum and Fastly already return 500 here (Add bounded after-response tasks on Fastly and Axum #509 treats a zero budget as a programming error). Cloudflare keeps 501 until After-response work on Cloudflare (waitUntil) #478.
  • No change to the capability matrix: Spin stays Unsupported, so required = ["after-response-tasks"] still refuses Spin at build/serve/deploy.

Stacked on #509 (feature/476-after-response-tasks at c3ba7e56), which adds RequestContext::after_response and the after-response-tasks capability. #483 is blocked by #476. #512 (Cloudflare, #478) is also stacked on #509. The two PRs overlap in two places: the after-response bullets in docs/guide/capabilities.md and the capability line in CHANGELOG.md. #512 also says "Spin installs no scheduler". Whichever lands second drops that sentence and the "tracked in #483" wording.

Design: docs/superpowers/specs/2026-11-18-spin-after-response-error-design.md; plan: docs/superpowers/plans/2026-11-18-spin-after-response-error.md.

Changes

Crate / File Change
edgezero-adapter-spin/src/after_response.rs (new) Rejecting AfterResponseScheduler: drops the task and returns EdgeError::not_implemented(AFTER_RESPONSE_UNSUPPORTED); host unit tests: poll and drop probes, and zero budget returns 500
edgezero-adapter-spin/src/lib.rs Ungated pub const AFTER_RESPONSE_UNSUPPORTED; module gated like ingress
edgezero-adapter-spin/src/request.rs into_core_request_head inserts the handle. This covers run_app, run_app_with_platform, dispatch_app, AppExt::dispatch, dispatch, dispatch_with_kv_label and into_core_request
edgezero-adapter-spin/tests/contract.rs wasm32 contract test: a real SpinRequest through dispatch_request to a route that registers a task gets the Spin 501; the task is never polled and is dropped once; a control route returns 200
edgezero-core/src/after_response.rs Doc-only: an unsupported adapter may install no handle or a rejecting one
docs/superpowers/specs/2026-11-17-after-response-tasks-design.md One-line pointer to this follow-up
docs/guide/capabilities.md, docs/guide/adapters/spin.md, CHANGELOG.md Spin's error documented; changelog no longer lists Spin as pending
docs/superpowers/{specs,plans}/2026-11-18-spin-after-response-error*.md Design and plan

Not covered, by construction: send_assembly_error (no app, no handlers) and the test-utils dispatch_ingress_* bridges, which build core requests directly. Both keep core's generic 501.

Closes

Closes #483

Test plan

Local, Rust 1.98.1 (pinned) and Node 24.20.0:

  • cargo test --workspace --all-targets (2824 passed)
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo fmt --all -- --check
  • cargo check --workspace --all-targets --features "fastly cloudflare spin"
  • WASM builds: wasm32-wasip2 (Spin): cargo check -p edgezero-adapter-spin --target wasm32-wasip2 --features spin, plus Spin wasm clippy for spin and spin,test-utils. Fastly and Cloudflare are untouched and were not rebuilt.
  • examples/app-demo workspace: cd examples/app-demo && cargo test --workspace --all-targets (68 passed)
  • Docs build: cd docs && npm run lint && npm run format && npm run build; node scripts/check_outbound_docs_contract.mjs
  • Manual testing via edgezero serve --adapter axum: not applicable (Spin-only change); runtime check below used Spin.
  • Other: Spin wasm32 --test contract --test sdk_resources under Wasmtime 48.0.2 (36 + 25 passed); adapter_capability_matrix_matches_contracts (--features cli).
  • Other, negative control: the contract test fails on the body comparison when the handle is not installed. Spin then returns core's generic message.
  • Other, runtime under spin up 4.1.0. A scratch copy of examples/app-demo got an /after-task route, which propagates the registration error with ? and whose task would print a stderr marker. The same copy was built from this branch and from Add bounded after-response tasks on Fastly and Axum #509:
    • This branch: 501 {"error":{"kind":"not_implemented","message":"after-response tasks are not supported by the Spin adapter","status":501}} on two consecutive requests.
    • Add bounded after-response tasks on Fastly and Axum #509 base: the same route returns 501 ... not supported by this adapter.
    • Task never runs: no task marker in the component stderr 3 s later. A control route that prints inline shows that stderr is captured.
    • Existing routes: / and /echo/spin return 200 on both builds.

Hosted Spin (Akamai Functions) was not exercised. GitHub CI is pending.

Checklist

  • Changes follow CLAUDE.md conventions
  • No Tokio deps added to core or adapter crates
  • Route params use {id} syntax (not :id)
  • Types imported from edgezero_core (not http crate)
  • Store wiring goes through KvRegistry / ConfigRegistry / SecretRegistry (not the legacy single-handle setters); store wiring is unchanged
  • New code has tests
  • No secrets or credentials committed

…e tasks

Spin does not run after-response tasks. Every converted Spin request now
carries a scheduler that rejects registration with 501 Not Implemented and
the message exported as edgezero_adapter_spin::AFTER_RESPONSE_UNSUPPORTED,
instead of core's generic "not supported by this adapter" message. The task
is dropped without being polled.

The handle is installed in into_core_request_head, which every native Spin
entry point uses (run_app, run_app_with_platform, dispatch_app,
AppExt::dispatch, dispatch, dispatch_with_kv_label, into_core_request).
The capability matrix already reports Spin Unsupported, so
required = ["after-response-tasks"] still refuses Spin.

Tests: host unit test for the scheduler; wasm32 contract test dispatching a
real SpinRequest. Docs: capabilities, Spin guide, changelog, core
after_response docs, design and plan.
@prk-Jr prk-Jr self-assigned this Nov 18, 2026
@prk-Jr prk-Jr changed the title Return an adapter-named capability error for Spin after-response tasks Name the Spin adapter in the after-response capability error Nov 18, 2026
Installing a rejecting Spin scheduler changes a zero budget from 501 to
500: core now finds a handle and rejects the budget before the
scheduler, as it already does on Axum and Fastly. The guides, changelog
and spec claimed every Spin registration returns 501 and that the zero
budget case was unchanged. Correct them and pin the 500 with a Spin unit
test.

Also note that core pre-dispatch hooks can replace or remove the handle
(removal falls back to core's 501), that PR #512 overlaps on the
CHANGELOG line as well as the capabilities bullet, and point the #509
design at the follow-up.
@prk-Jr
prk-Jr added this pull request to stack #516 November 18, 2026 18:17
@prk-Jr prk-Jr linked an issue Nov 18, 2026 that may be closed by this pull request
2 tasks
@prk-Jr
prk-Jr marked this pull request as ready for review November 18, 2026 19:04
@aram356
aram356 removed this pull request from stack #516 November 19, 2026 05:02
@aram356
aram356 changed the base branch from feature/476-after-response-tasks to feature/478-cloudflare-after-response November 19, 2026 05:03
@aram356
aram356 added this pull request to stack #511 November 19, 2026 05:03
aram356 added a commit that referenced this pull request Nov 19, 2026
#509 (2620377) adds bounded work after the response on Fastly and Axum, drained on Axum SIGTERM (EZI-1, #476). #512 (cdc232c) runs it on Cloudflare through waitUntil (#478), and #515 (ec347a2) reports Spin's capability error (#483). The line now stacks on #517 and each PR merged the one below it, so this merge is clean.
@aram356

aram356 commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

For Trusted Server's identity integration chain, this PR now stacks on #512 instead of #509: the two conflicted in CHANGELOG.md and docs/guide/capabilities.md, so one of them had to land second. ec347a2c merges #512's head cdc232c8. The changelog takes #512's capability wording without "(tracked in #483)", which this PR removes, then this PR's Spin 501 and zero-budget 500 bullet; capabilities.md keeps #512's Cloudflare waitUntil bullet and replaces its Spin line with this PR's. The base is now feature/478-cloudflare-after-response, and the PR sits above #512 in stack 511. No behavior or test changes.

Checked locally at ec347a2c: cargo fmt, workspace clippy with all features, both Fastly clippy runs, the wasm feature check, cargo test --workspace --all-targets (3,118 passed), the Spin contract tests under Wasmtime (41), and the per-adapter clippy matrix, all passing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After-response capability error on Spin

2 participants